Method: ThemeCheck::RemoteAsset#on_element

Defined in:
lib/theme_check/checks/remote_asset.rb

#on_element(node) ⇒ Object 



14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
 
# File 'lib/theme_check/checks/remote_asset.rb', line 14

def on_element(node)
  return unless TAGS.include?(node.name)

  resource_url = node.attributes["src"] || node.attributes["href"]
  return if resource_url.nil? || resource_url.empty?

  # Ignore if URL is Liquid, taken care of by AssetUrlFilters check
  return if resource_url.start_with?(CDN_ROOT)
  return if resource_url =~ ABSOLUTE_PATH
  return if resource_url =~ RELATIVE_PATH
  return if url_hosted_by_shopify?(resource_url)
  return if url_is_setting_variable?(resource_url)

  # Ignore non-stylesheet link tags
  rel = node.attributes["rel"]
  return if node.name == "link" && rel != "stylesheet"

  add_offense(
    "Asset should be served by the Shopify CDN for better performance.",
    node: node,
  )
end