Class: Spektr::Checks::ContentTagXss

Inherits:
Base
  • Object
show all
Defined in:
lib/spektr/checks/content_tag_xss.rb

Instance Attribute Summary

Attributes inherited from Base

#name

Instance Method Summary collapse

Methods inherited from Base

#app_version_between?, #dupe?, #full_receiver, #model_attribute?, #receivers_for, #should_run?, #target_affected?, #user_input?, #version_affected, #version_between?, #warn!

Constructor Details

#initialize(app, target) ⇒ ContentTagXss

Checks for unescaped values in content_tag

content_tag :tag, body
                  ^-- Unescaped in Rails 2.x

content_tag, :tag, body, attribute => value
                           ^-- Unescaped in all versions

TODO:

content_tag, :tag, body, attribute => value
                                       ^
                                       |
       Escaped by default, can be explicitly escaped
       or not by passing in (true|false) as fourth argument


17
18
19
20
21
22
 
# File 'lib/spektr/checks/content_tag_xss.rb', line 17

def initialize(app, target)
  super
  @name = "XSS in content_tag"
  @type = "Cross-Site Scripting"
  @targets = ["Spektr::Targets::Base", "Spektr::Targets::View"]
end

Instance Method Details

#cve_2016_6316_check(calls) ⇒ Object 



56
57
58
59
60
 
# File 'lib/spektr/checks/content_tag_xss.rb', line 56

def cve_2016_6316_check(calls)
  if calls.any? && app_version_between?("3.0.0", "3.2.22.3") || app_version_between?("4.0.0", "4.2.7.0") || app_version_between?("5.0.0", "5.0.0.0")
    warn! @target, self, calls.first.location, "Rails #{@app.rails_version} does not escape double quotes in attribute values"
  end
end

#run ⇒ Object 



24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
 
# File 'lib/spektr/checks/content_tag_xss.rb', line 24

def run
  return unless super
  return unless @app.rails_version
  calls = @target.find_calls(:content_tag)
  # https://groups.google.com/d/msg/ruby-security-ann/8B2iV2tPRSE/JkjCJkSoCgAJ
  cve_2016_6316_check(calls)

  calls.each do |call|
    call.arguments.is_a?(Prism::ArgumentsNode) ? arguments = call.arguments.arguments : call.arguments
    arguments.each do |argument|
      if user_input?(argument) && @app.rails_version < Gem::Version.new("3.0")
        warn! @target, self, call.location, "Unescaped parameter in content_tag in Rails < 3.0"
      end
      if argument.is_a?(Prism::KeywordHashNode)
        argument.elements.each do |element|
          if user_input?(element.key)
            warn! @target, self, call.location, "Unescaped parameter in content_tag at #{element.key.name}"
          end
        end
      end
    end

    # if call.options.any?
    #   call.options.each_value do |option|
    #     if user_input?(option.key.type, option.key.children.last)
    #       warn! @target, self, call.location, "Unescaped attribute name in content_tag"
    #     end
    #   end
    # end
  end
end