Class: RuboCop::Cop::Style::UnlessElse

Inherits:
Base
  • Object
show all
Extended by:
AutoCorrector
Includes:
RangeHelp
Defined in:
lib/rubocop/cop/style/unless_else.rb

Overview

This cop looks for `unless` expressions with `else` clauses.

Examples:

# bad
unless foo_bar.nil?
  # do something...
else
  # do a different thing...
end

# good
if foo_bar.present?
  # do something...
else
  # do a different thing...
end

Constant Summary collapse

MSG =
'Do not use `unless` with `else`. Rewrite these with the positive case first.'

Constants inherited from Base

Base::RESTRICT_ON_SEND

Instance Attribute Summary

Attributes inherited from Base

#config, #processed_source

Instance Method Summary collapse

Methods included from AutoCorrector

support_autocorrect?

Methods inherited from Base

#add_global_offense, #add_offense, autocorrect_incompatible_with, badge, #callbacks_needed, callbacks_needed, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, #cop_name, cop_name, department, documentation_url, exclude_from_registry, #excluded_file?, #external_dependency_checksum, inherited, #initialize, joining_forces, lint?, match?, #message, #offenses, #on_investigation_end, #on_new_investigation, #on_other_file, #parse, #ready, #relevant_file?, support_autocorrect?, support_multiple_source?, #target_rails_version, #target_ruby_version

Methods included from ExcludeLimit

#exclude_limit

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

silence_warnings

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#on_if(node) ⇒ Object


28
29
30
31
32
33
34
35
36
37
38
39
# File 'lib/rubocop/cop/style/unless_else.rb', line 28

def on_if(node)
  return unless node.unless? && node.else?

  add_offense(node) do |corrector|
    body_range = range_between_condition_and_else(node, node.condition)
    else_range = range_between_else_and_end(node)

    corrector.replace(node.loc.keyword, 'if')
    corrector.replace(body_range, else_range.source)
    corrector.replace(else_range, body_range.source)
  end
end

#range_between_condition_and_else(node, condition) ⇒ Object


41
42
43
# File 'lib/rubocop/cop/style/unless_else.rb', line 41

def range_between_condition_and_else(node, condition)
  range_between(condition.source_range.end_pos, node.loc.else.begin_pos)
end

#range_between_else_and_end(node) ⇒ Object


45
46
47
# File 'lib/rubocop/cop/style/unless_else.rb', line 45

def range_between_else_and_end(node)
  range_between(node.loc.else.end_pos, node.loc.end.begin_pos)
end