Class: RuboCop::Cop::Style::SymbolProc

Inherits:
Cop
  • Object
show all
Includes:
IgnoredMethods, RangeHelp
Defined in:
lib/rubocop/cop/style/symbol_proc.rb

Overview

Use symbols as procs when possible.

Examples:

# bad
something.map { |s| s.upcase }

# good
something.map(&:upcase)

Constant Summary collapse

MSG = 
'Pass `&:%<method>s` as an argument to `%<block_method>s` ' \
'instead of a block.'
SUPER_TYPES = 
%i[super zsuper].freeze

Constants included from Util

Util::LITERAL_REGEX

Instance Attribute Summary

Attributes inherited from Cop

#config, #corrections, #offenses, #processed_source

Class Method Summary collapse

Instance Method Summary collapse

Methods inherited from Cop

#add_offense, all, badge, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, cop_name, #cop_name, #correct, department, #disable_uncorrectable, #duplicate_location?, #excluded_file?, #find_location, #highlights, inherited, #initialize, #join_force?, lint?, match?, #message, #messages, #parse, qualified_cop_name, #reason_to_not_correct, #relevant_file?, #target_rails_version, #target_ruby_version

Methods included from NodePattern::Macros

#def_node_matcher, #def_node_search, #node_search, #node_search_all, #node_search_body, #node_search_first

Methods included from AST::Sexp

#s

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #correctable?, #disable_offense, #disable_uncorrectable?, #support_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

begins_its_line?, comment_line?, double_quotes_required?, escape_string, first_part_of_call_chain, interpret_string_escapes, line_range, needs_escaping?, on_node, parentheses?, same_line?, to_string_literal, to_supported_styles, tokens, trim_string_interporation_escape_character

Methods included from PathUtil

absolute?, chdir, hidden_dir?, hidden_file_in_not_hidden_dir?, match_path?, pwd, relative_path, reset_pwd, smart_path

Constructor Details

This class inherits a constructor from RuboCop::Cop::Cop

Class Method Details

.autocorrect_incompatible_with ⇒ Object 


30
31
32
 
# File 'lib/rubocop/cop/style/symbol_proc.rb', line 30

def self.autocorrect_incompatible_with
  [Layout::SpaceBeforeBlockBraces]
end

Instance Method Details

#autocorrect(node) ⇒ Object 


52
53
54
55
56
57
58
59
60
61
62
 
# File 'lib/rubocop/cop/style/symbol_proc.rb', line 52

def autocorrect(node)
  lambda do |corrector|
    if node.send_node.arguments?
      autocorrect_with_args(corrector, node,
                            node.send_node.arguments,
                            node.body.method_name)
    else
      autocorrect_without_args(corrector, node)
    end
  end
end

#destructuring_block_argument?(argument_node) ⇒ Boolean 


48
49
50
 
# File 'lib/rubocop/cop/style/symbol_proc.rb', line 48

def destructuring_block_argument?(argument_node)
  argument_node.one? && argument_node.source.include?(',')
end

#on_block(node) ⇒ Object 


34
35
36
37
38
39
40
41
42
43
44
45
46
 
# File 'lib/rubocop/cop/style/symbol_proc.rb', line 34

def on_block(node)
  symbol_proc?(node) do |dispatch_node, arguments_node, method_name|
    # TODO: Rails-specific handling that we should probably make
    # configurable - https://github.com/rubocop-hq/rubocop/issues/1485
    # we should ignore lambdas & procs
    return if proc_node?(dispatch_node)
    return if %i[lambda proc].include?(dispatch_node.method_name)
    return if ignored_method?(dispatch_node.method_name)
    return if destructuring_block_argument?(arguments_node)

    register_offense(node, method_name, dispatch_node.method_name)
  end
end