Class: RuboCop::Cop::Style::SoleNestedConditional

Inherits:
Base
  • Object
show all
Extended by:
AutoCorrector
Includes:
RangeHelp
Defined in:
lib/rubocop/cop/style/sole_nested_conditional.rb

Overview

If the branch of a conditional consists solely of a conditional node, its conditions can be combined with the conditions of the outer branch. This helps to keep the nesting level from getting too deep.

Examples:

# bad
if condition_a
  if condition_b
    do_something
  end
end

# good
if condition_a && condition_b
  do_something
end

AllowModifier: false (default)

# bad
if condition_a
  do_something if condition_b
end

AllowModifier: true

# good
if condition_a
  do_something if condition_b
end

Constant Summary collapse

MSG =
'Consider merging nested conditions into outer `%<conditional_type>s` conditions.'

Constants inherited from Base

Base::RESTRICT_ON_SEND

Instance Attribute Summary

Attributes inherited from Base

#config, #processed_source

Class Method Summary collapse

Instance Method Summary collapse

Methods included from AutoCorrector

support_autocorrect?

Methods inherited from Base

#add_global_offense, #add_offense, badge, #callbacks_needed, callbacks_needed, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, #cop_name, cop_name, department, documentation_url, exclude_from_registry, #excluded_file?, #external_dependency_checksum, inherited, #initialize, joining_forces, lint?, match?, #message, #offenses, #on_investigation_end, #on_new_investigation, #on_other_file, #parse, #ready, #relevant_file?, support_autocorrect?, support_multiple_source?, #target_rails_version, #target_ruby_version

Methods included from ExcludeLimit

#exclude_limit

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

silence_warnings

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Class Method Details

.autocorrect_incompatible_withObject


41
42
43
# File 'lib/rubocop/cop/style/sole_nested_conditional.rb', line 41

def self.autocorrect_incompatible_with
  [Style::NegatedIf, Style::NegatedUnless]
end

Instance Method Details

#on_if(node) ⇒ Object


45
46
47
48
49
50
51
52
53
54
55
56
# File 'lib/rubocop/cop/style/sole_nested_conditional.rb', line 45

def on_if(node)
  return if node.ternary? || node.else? || node.elsif?

  if_branch = node.if_branch
  return if use_variable_assignment_in_condition?(node.condition, if_branch)
  return unless offending_branch?(if_branch)

  message = format(MSG, conditional_type: node.keyword)
  add_offense(if_branch.loc.keyword, message: message) do |corrector|
    autocorrect(corrector, node, if_branch)
  end
end