Class: RuboCop::Cop::Style::RedundantSortBy

Inherits:
Base
  • Object
show all
Extended by:
AutoCorrector
Includes:
RangeHelp
Defined in:
lib/rubocop/cop/style/redundant_sort_by.rb

Overview

This cop identifies places where `sort_by { … }` can be replaced by `sort`.

Examples:

# bad
array.sort_by { |x| x }
array.sort_by do |var|
  var
end

# good
array.sort

Constant Summary collapse

MSG =
'Use `sort` instead of `sort_by { |%<var>s| %<var>s }`.'

Constants inherited from Base

Base::RESTRICT_ON_SEND

Instance Attribute Summary

Attributes inherited from Base

#config, #processed_source

Instance Method Summary collapse

Methods included from AutoCorrector

support_autocorrect?

Methods inherited from Base

#add_global_offense, #add_offense, autocorrect_incompatible_with, badge, #callbacks_needed, callbacks_needed, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, #cop_name, cop_name, department, documentation_url, exclude_from_registry, #excluded_file?, #external_dependency_checksum, inherited, #initialize, joining_forces, lint?, match?, #message, #offenses, #on_investigation_end, #on_new_investigation, #on_other_file, #parse, #ready, #relevant_file?, support_autocorrect?, support_multiple_source?, #target_rails_version, #target_ruby_version

Methods included from ExcludeLimit

#exclude_limit

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

silence_warnings

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#on_block(node) ⇒ Object


29
30
31
32
33
34
35
36
37
# File 'lib/rubocop/cop/style/redundant_sort_by.rb', line 29

def on_block(node)
  redundant_sort_by(node) do |send, var_name|
    range = sort_by_range(send, node)

    add_offense(range, message: format(MSG, var: var_name)) do |corrector|
      corrector.replace(range, 'sort')
    end
  end
end

#redundant_sort_by(node) ⇒ Object


25
26
27
# File 'lib/rubocop/cop/style/redundant_sort_by.rb', line 25

def_node_matcher :redundant_sort_by, <<~PATTERN
  (block $(send _ :sort_by) (args (arg $_x)) (lvar _x))
PATTERN