Class: RuboCop::Cop::Style::IfWithSemicolon

Inherits:
Base
  • Object
show all
Extended by:
AutoCorrector
Includes:
OnNormalIfUnless
Defined in:
lib/rubocop/cop/style/if_with_semicolon.rb

Overview

Checks for uses of semicolon in if statements.

Examples:


# bad
result = if some_condition; something else another_thing end

# good
result = some_condition ? something : another_thing

Constant Summary collapse

MSG_IF_ELSE =
'Do not use `if %<expr>s;` - use `if/else` instead.'
MSG_TERNARY =
'Do not use `if %<expr>s;` - use a ternary operator instead.'

Constants inherited from Base

Base::RESTRICT_ON_SEND

Instance Attribute Summary

Attributes inherited from Base

#config, #processed_source

Instance Method Summary collapse

Methods included from AutoCorrector

support_autocorrect?

Methods included from OnNormalIfUnless

#on_if

Methods inherited from Base

#add_global_offense, #add_offense, autocorrect_incompatible_with, badge, #callbacks_needed, callbacks_needed, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, #cop_name, cop_name, department, documentation_url, exclude_from_registry, #excluded_file?, #external_dependency_checksum, inherited, #initialize, joining_forces, lint?, match?, #message, #offenses, #on_investigation_end, #on_new_investigation, #on_other_file, #parse, #ready, #relevant_file?, support_autocorrect?, support_multiple_source?, #target_rails_version, #target_ruby_version

Methods included from ExcludeLimit

#exclude_limit

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

silence_warnings

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#on_normal_if_unless(node) ⇒ Object


23
24
25
26
27
28
29
30
31
32
33
34
35
# File 'lib/rubocop/cop/style/if_with_semicolon.rb', line 23

def on_normal_if_unless(node)
  return unless node.else_branch
  return if node.parent&.if_type?

  beginning = node.loc.begin
  return unless beginning&.is?(';')

  message = node.else_branch.if_type? ? MSG_IF_ELSE : MSG_TERNARY

  add_offense(node, message: format(message, expr: node.condition.source)) do |corrector|
    corrector.replace(node, autocorrect(node))
  end
end