Class: RuboCop::Cop::Style::EachForSimpleLoop

Inherits:
Base
  • Object
show all
Extended by:
AutoCorrector
Defined in:
lib/rubocop/cop/style/each_for_simple_loop.rb

Overview

Checks for loops which iterate a constant number of times, using a Range literal and ‘#each`. This can be done more readably using `Integer#times`.

This check only applies if the block takes no parameters.

Examples:

# bad
(1..5).each { }

# good
5.times { }
# bad
(0...10).each {}

# good
10.times {}

Constant Summary collapse

MSG = 
'Use `Integer#times` for a simple loop which iterates a fixed number of times.'

Constants inherited from Base

Base::RESTRICT_ON_SEND

Instance Attribute Summary

Attributes inherited from Base

#config, #processed_source

Instance Method Summary collapse

Methods included from AutoCorrector

support_autocorrect?

Methods inherited from Base

#active_support_extensions_enabled?, #add_global_offense, #add_offense, autocorrect_incompatible_with, badge, #begin_investigation, callbacks_needed, #callbacks_needed, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, cop_name, #cop_name, department, documentation_url, exclude_from_registry, #excluded_file?, #external_dependency_checksum, inherited, #initialize, #inspect, joining_forces, lint?, match?, #message, #offenses, #on_investigation_end, #on_new_investigation, #on_other_file, #parse, #ready, #relevant_file?, support_autocorrect?, support_multiple_source?, #target_rails_version, #target_ruby_version

Methods included from ExcludeLimit

#exclude_limit

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #autocorrect_with_disable_uncorrectable?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

silence_warnings

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#on_block(node) ⇒ Object

rubocop:disable InternalAffairs/NumblockHandler



30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
 
# File 'lib/rubocop/cop/style/each_for_simple_loop.rb', line 30

def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
  return unless offending?(node)

  send_node = node.send_node

  range = send_node.receiver.source_range.join(send_node.loc.selector)

  add_offense(range) do |corrector|
    range_type, min, max = each_range(node)

    max += 1 if range_type == :irange

    corrector.replace(node.send_node, "#{max - min}.times")
  end
end