Class: RuboCop::Cop::Lint::SelfAssignment

Inherits:
Base
  • Object
show all
Defined in:
lib/rubocop/cop/lint/self_assignment.rb

Overview

Checks for self-assignments.

Examples:

# bad
foo = foo
foo, bar = foo, bar
Foo = Foo
hash['foo'] = hash['foo']
obj.attr = obj.attr

# good
foo = bar
foo, bar = bar, foo
Foo = Bar
hash['foo'] = hash['bar']
obj.attr = obj.attr2

# good (method calls possibly can return different results)
hash[foo] = hash[foo]

Constant Summary collapse

MSG = 
'Self-assignment detected.'
ASSIGNMENT_TYPE_TO_RHS_TYPE = 
{
  lvasgn: :lvar,
  ivasgn: :ivar,
  cvasgn: :cvar,
  gvasgn: :gvar
}.freeze

Constants inherited from Base

Base::RESTRICT_ON_SEND

Instance Attribute Summary

Attributes inherited from Base

#config, #processed_source

Instance Method Summary collapse

Methods inherited from Base

#active_support_extensions_enabled?, #add_global_offense, #add_offense, #always_autocorrect?, autocorrect_incompatible_with, badge, #begin_investigation, callbacks_needed, #callbacks_needed, #config_to_allow_offenses, #config_to_allow_offenses=, #contextual_autocorrect?, #cop_config, cop_name, #cop_name, department, documentation_url, exclude_from_registry, #excluded_file?, #external_dependency_checksum, inherited, #initialize, #inspect, joining_forces, lint?, match?, #message, #offenses, #on_investigation_end, #on_new_investigation, #on_other_file, #parse, #parser_engine, #ready, #relevant_file?, requires_gem, support_autocorrect?, support_multiple_source?, #target_rails_version, #target_ruby_version

Methods included from ExcludeLimit

#exclude_limit

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #autocorrect_with_disable_uncorrectable?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

silence_warnings

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#on_casgn(node) ⇒ Object 



57
58
59
60
61
62
63
 
# File 'lib/rubocop/cop/lint/self_assignment.rb', line 57

def on_casgn(node)
  lhs_scope, lhs_name, rhs = *node
  return unless rhs&.const_type?

  rhs_scope, rhs_name = *rhs
  add_offense(node) if lhs_scope == rhs_scope && lhs_name == rhs_name
end

#on_lvasgn(node) ⇒ Object Also known as: on_ivasgn, on_cvasgn, on_gvasgn 



45
46
47
48
49
50
51
52
 
# File 'lib/rubocop/cop/lint/self_assignment.rb', line 45

def on_lvasgn(node)
  lhs, rhs = *node
  return unless rhs

  rhs_type = ASSIGNMENT_TYPE_TO_RHS_TYPE[node.type]

  add_offense(node) if rhs.type == rhs_type && rhs.source == lhs.to_s
end

#on_masgn(node) ⇒ Object 



65
66
67
 
# File 'lib/rubocop/cop/lint/self_assignment.rb', line 65

def on_masgn(node)
  add_offense(node) if multiple_self_assignment?(node)
end

#on_or_asgn(node) ⇒ Object Also known as: on_and_asgn 



69
70
71
72
 
# File 'lib/rubocop/cop/lint/self_assignment.rb', line 69

def on_or_asgn(node)
  lhs, rhs = *node
  add_offense(node) if rhs_matches_lhs?(rhs, lhs)
end

#on_send(node) ⇒ Object Also known as: on_csend 



36
37
38
39
40
41
42
 
# File 'lib/rubocop/cop/lint/self_assignment.rb', line 36

def on_send(node)
  if node.method?(:[]=)
    handle_key_assignment(node) if node.arguments.size == 2
  elsif node.assignment_method?
    handle_attribute_assignment(node) if node.arguments.size == 1
  end
end