Class: RuboCop::Cop::Lint::ImplicitStringConcatenation

Inherits:
Base
  • Object
show all
Defined in:
lib/rubocop/cop/lint/implicit_string_concatenation.rb

Overview

This cop checks for implicit string concatenation of string literals which are on the same line.

Examples:


# bad

array = ['Item 1' 'Item 2']

# good

array = ['Item 1Item 2']
array = ['Item 1' + 'Item 2']
array = [
  'Item 1' \
  'Item 2'
]

Constant Summary collapse

MSG =
'Combine %<string1>s and %<string2>s into a single string ' \
'literal, rather than using implicit string concatenation.'
FOR_ARRAY =
' Or, if they were intended to be separate array ' \
'elements, separate them with a comma.'
FOR_METHOD =
' Or, if they were intended to be separate method ' \
'arguments, separate them with a comma.'

Constants inherited from Base

Base::RESTRICT_ON_SEND

Instance Attribute Summary

Attributes inherited from Base

#config, #processed_source

Instance Method Summary collapse

Methods inherited from Base

#add_global_offense, #add_offense, autocorrect_incompatible_with, badge, #callbacks_needed, callbacks_needed, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, #cop_name, cop_name, department, documentation_url, exclude_from_registry, #excluded_file?, #external_dependency_checksum, inherited, #initialize, joining_forces, lint?, match?, #message, #offenses, #on_investigation_end, #on_new_investigation, #on_other_file, #parse, #ready, #relevant_file?, support_autocorrect?, support_multiple_source?, #target_rails_version, #target_ruby_version

Methods included from ExcludeLimit

#exclude_limit

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

silence_warnings

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#on_dstr(node) ⇒ Object


33
34
35
36
37
38
39
40
41
42
43
44
45
46
# File 'lib/rubocop/cop/lint/implicit_string_concatenation.rb', line 33

def on_dstr(node)
  each_bad_cons(node) do |child_node1, child_node2|
    range   = child_node1.source_range.join(child_node2.source_range)
    message = format(MSG,
                     string1: display_str(child_node1),
                     string2: display_str(child_node2))
    if node.parent&.array_type?
      message << FOR_ARRAY
    elsif node.parent&.send_type?
      message << FOR_METHOD
    end
    add_offense(range, message: message)
  end
end