Class: RuboCop::Cop::Lint::DuplicateRescueException

Inherits:
Base
  • Object
show all
Includes:
RescueNode
Defined in:
lib/rubocop/cop/lint/duplicate_rescue_exception.rb

Overview

This cop checks that there are no repeated exceptions used in 'rescue' expressions.

Examples:

# bad
begin
  something
rescue FirstException
  handle_exception
rescue FirstException
  handle_other_exception
end

# good
begin
  something
rescue FirstException
  handle_exception
rescue SecondException
  handle_other_exception
end

Constant Summary collapse

MSG =
'Duplicate `rescue` exception detected.'

Constants inherited from Base

Base::RESTRICT_ON_SEND

Instance Attribute Summary

Attributes inherited from Base

#config, #processed_source

Instance Method Summary collapse

Methods included from RescueNode

#on_new_investigation

Methods inherited from Base

#add_global_offense, #add_offense, autocorrect_incompatible_with, badge, #callbacks_needed, callbacks_needed, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, #cop_name, cop_name, department, documentation_url, exclude_from_registry, #excluded_file?, #external_dependency_checksum, inherited, #initialize, joining_forces, lint?, match?, #message, #offenses, #on_investigation_end, #on_new_investigation, #on_other_file, #parse, #ready, #relevant_file?, support_autocorrect?, support_multiple_source?, #target_rails_version, #target_ruby_version

Methods included from ExcludeLimit

#exclude_limit

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

silence_warnings

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#on_rescue(node) ⇒ Object


33
34
35
36
37
38
39
40
41
42
43
# File 'lib/rubocop/cop/lint/duplicate_rescue_exception.rb', line 33

def on_rescue(node)
  return if rescue_modifier?(node)

  node.resbody_branches.each_with_object(Set.new) do |resbody, previous|
    rescued_exceptions = resbody.exceptions

    rescued_exceptions.each do |exception|
      add_offense(exception) unless previous.add?(exception)
    end
  end
end