Class: RuboCop::Cop::Lint::DuplicateElsifCondition

Inherits:
Base
  • Object
show all
Defined in:
lib/rubocop/cop/lint/duplicate_elsif_condition.rb

Overview

This cop checks that there are no repeated conditions used in if 'elsif'.

Examples:

# bad
if x == 1
  do_something
elsif x == 1
  do_something_else
end

# good
if x == 1
  do_something
elsif x == 2
  do_something_else
end

Constant Summary collapse

MSG =
'Duplicate `elsif` condition detected.'

Constants inherited from Base

Base::RESTRICT_ON_SEND

Instance Attribute Summary

Attributes inherited from Base

#config, #processed_source

Instance Method Summary collapse

Methods inherited from Base

#add_global_offense, #add_offense, autocorrect_incompatible_with, badge, #callbacks_needed, callbacks_needed, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, #cop_name, cop_name, department, documentation_url, exclude_from_registry, #excluded_file?, #external_dependency_checksum, inherited, #initialize, joining_forces, lint?, match?, #message, #offenses, #on_investigation_end, #on_new_investigation, #on_other_file, #parse, #ready, #relevant_file?, support_autocorrect?, support_multiple_source?, #target_rails_version, #target_ruby_version

Methods included from ExcludeLimit

#exclude_limit

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

silence_warnings

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#on_if(node) ⇒ Object


26
27
28
29
30
31
32
33
34
35
# File 'lib/rubocop/cop/lint/duplicate_elsif_condition.rb', line 26

def on_if(node)
  previous = []
  while node.if? || node.elsif?
    condition = node.condition
    add_offense(condition) if previous.include?(condition)
    previous << condition
    node = node.else_branch
    break unless node&.if_type?
  end
end