Class: RuboCop::Cop::Lint::BinaryOperatorWithIdenticalOperands

Inherits:
Base
  • Object
show all
Defined in:
lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb

Overview

This cop checks for places where binary operator has identical operands.

It covers arithmetic operators: `+`, `-`, `*`, `/`, `%`, `**`; comparison operators: `==`, `===`, `=~`, `>`, `>=`, `<`, `<=`; bitwise operators: `|`, `^`, `&`, `<<`, `>>`; boolean operators: `&&`, `||` and “spaceship” operator - `<=>`.

This cop is marked as unsafe as it does not consider side effects when calling methods and thus can generate false positives:

if wr.take_char == '\0' && wr.take_char == '\0'

Examples:

# bad
x / x
x.top >= x.top

if a.x != 0 && a.x != 0
  do_something
end

def childs?
  left_child || left_child
end

# good
x + x
1 << 1

Constant Summary collapse

MSG =
'Binary operator `%<op>s` has identical operands.'
ALLOWED_MATH_OPERATORS =
%i[+ * ** << >>].to_set.freeze

Constants inherited from Base

Base::RESTRICT_ON_SEND

Instance Attribute Summary

Attributes inherited from Base

#config, #processed_source

Instance Method Summary collapse

Methods inherited from Base

#add_global_offense, #add_offense, autocorrect_incompatible_with, badge, #callbacks_needed, callbacks_needed, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, #cop_name, cop_name, department, documentation_url, exclude_from_registry, #excluded_file?, #external_dependency_checksum, inherited, #initialize, joining_forces, lint?, match?, #message, #offenses, #on_investigation_end, #on_new_investigation, #on_other_file, #parse, #ready, #relevant_file?, support_autocorrect?, support_multiple_source?, #target_rails_version, #target_ruby_version

Methods included from ExcludeLimit

#exclude_limit

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

silence_warnings

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#on_and(node) ⇒ Object Also known as: on_or


48
49
50
# File 'lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb', line 48

def on_and(node)
  add_offense(node, message: format(MSG, op: node.operator)) if node.lhs == node.rhs
end

#on_send(node) ⇒ Object


39
40
41
42
43
44
45
46
# File 'lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb', line 39

def on_send(node)
  return unless node.binary_operation?

  lhs, operation, rhs = *node
  return if ALLOWED_MATH_OPERATORS.include?(node.method_name)

  add_offense(node, message: format(MSG, op: operation)) if lhs == rhs
end