Class: RuboCop::Cop::Lint::BinaryOperatorWithIdenticalOperands

Inherits:
Base
  • Object
show all
Defined in:
lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb

Overview

This cop checks for places where binary operator has identical operands.

It covers arithmetic operators: ‘+`, `-`, `*`, `/`, `%`, `**`; comparison operators: `==`, `===`, `=~`, `>`, `>=`, `<`, `<=`; bitwise operators: `|`, `^`, `&`, `<<`, `>>`; boolean operators: `&&`, `||` and “spaceship” operator - `<=>`.

This cop is marked as unsafe as it does not consider side effects when calling methods and thus can generate false positives:

if wr.take_char == '\0' && wr.take_char == '\0'

Examples:

# bad
x.top >= x.top

if a.x != 0 && a.x != 0
  do_something
end

def childs?
  left_child || left_child
end

Constant Summary collapse

MSG = 
'Binary operator `%<op>s` has identical operands.'
MATH_OPERATORS = 
%i[+ - * / % ** << >> | ^].to_set.freeze

Constants inherited from Base

Base::RESTRICT_ON_SEND

Constants included from Util

Util::LITERAL_REGEX

Instance Attribute Summary

Attributes inherited from Base

#config, #processed_source

Instance Method Summary collapse

Methods inherited from Base

#add_global_offense, #add_offense, autocorrect_incompatible_with, badge, #callbacks_needed, callbacks_needed, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, #cop_name, cop_name, department, documentation_url, exclude_from_registry, #excluded_file?, #external_dependency_checksum, inherited, #initialize, joining_forces, lint?, match?, #message, #offenses, #on_investigation_end, #on_new_investigation, #on_other_file, #ready, #relevant_file?, support_autocorrect?, support_multiple_source?, #target_rails_version, #target_ruby_version

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

add_parentheses, args_begin, args_end, begins_its_line?, comment_line?, comment_lines?, double_quotes_required?, escape_string, first_part_of_call_chain, indent, interpret_string_escapes, line_range, needs_escaping?, on_node, parentheses?, same_line?, to_string_literal, to_supported_styles, trim_string_interporation_escape_character

Methods included from PathUtil

absolute?, hidden_dir?, hidden_file?, hidden_file_in_not_hidden_dir?, match_path?, maybe_hidden_file?, relative_path, smart_path

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#on_and(node) ⇒ Object Also known as: on_or 



43
44
45
 
# File 'lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb', line 43

def on_and(node)
  add_offense(node, message: format(MSG, op: node.operator)) if node.lhs == node.rhs
end

#on_send(node) ⇒ Object 



34
35
36
37
38
39
40
41
 
# File 'lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb', line 34

def on_send(node)
  return unless node.binary_operation?

  lhs, operation, rhs = *node
  return if MATH_OPERATORS.include?(node.method_name) && lhs.basic_literal?

  add_offense(node, message: format(MSG, op: operation)) if lhs == rhs
end