Class: RuboCop::Cop::Lint::ImplicitStringConcatenation

Inherits:
Cop
  • Object
show all
Defined in:
lib/rubocop/cop/lint/implicit_string_concatenation.rb

Overview

This cop checks for implicit string concatenation of string literals which are on the same line.

Examples:

@bad
array = ['Item 1' 'Item 2']

@good
array = ['Item 1Item 2']
array = ['Item 1' + 'Item 2']
array = [
  'Item 1' \
  'Item 2'
]

Constant Summary collapse

MSG =
'Combine %s and %s into a single string literal, rather than ' \
'using implicit string concatenation.'.freeze
FOR_ARRAY =
' Or, if they were intended to be separate array ' \
'elements, separate them with a comma.'.freeze
FOR_METHOD =
' Or, if they were intended to be separate method ' \
'arguments, separate them with a comma.'.freeze

Constants included from Util

Util::ASGN_NODES, Util::BYTE_ORDER_MARK, Util::EQUALS_ASGN_NODES, Util::LITERAL_REGEX, Util::OPERATOR_METHODS, Util::SHORTHAND_ASGN_NODES

Instance Attribute Summary

Attributes inherited from Cop

#config, #corrections, #offenses, #processed_source

Instance Method Summary collapse

Methods inherited from Cop

#add_offense, all, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, cop_name, #cop_name, cop_type, #correct, #debug?, #details, #display_cop_names?, #display_style_guide?, #duplicate_location?, #excluded_file?, #extra_details?, #find_location, #highlights, inherited, #initialize, #join_force?, lint?, match?, #message, #messages, non_rails, #parse, qualified_cop_name, #reference_url, #relevant_file?, #style_guide_url, #target_ruby_version

Methods included from Sexp

#s

Methods included from NodePattern::Macros

#def_node_matcher, #def_node_search, #node_search, #node_search_all, #node_search_body, #node_search_first

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #support_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

begins_its_line?, block_length, comment_line?, compatible_external_encoding_for?, directions, double_quotes_acceptable?, double_quotes_required?, effective_column, ends_its_line?, escape_string, first_part_of_call_chain, hard_to_type?, interpret_string_escapes, line_distance, line_range, move_pos, needs_escaping?, numeric_range_size, on_node, operator?, parentheses?, parenthesized_call?, preceed?, range_between, range_with_surrounding_comma, range_with_surrounding_space, same_line?, source_range, strip_quotes, stripped_source_upto, to_string_literal, to_symbol_literal, within_node?

Methods included from PathUtil

absolute?, match_path?, relative_path

Constructor Details

This class inherits a constructor from RuboCop::Cop::Cop

Instance Method Details

#on_dstr(node) ⇒ Object



28
29
30
31
32
33
34
35
36
37
38
39
# File 'lib/rubocop/cop/lint/implicit_string_concatenation.rb', line 28

def on_dstr(node)
  each_bad_cons(node) do |child1, child2|
    range   = child1.source_range.join(child2.source_range)
    message = format(MSG, display_str(child1), display_str(child2))
    if node.parent && node.parent.array_type?
      message << FOR_ARRAY
    elsif node.parent && node.parent.send_type?
      message << FOR_METHOD
    end
    add_offense(node, range, message)
  end
end