Class: RuboCop::Cop::Style::OneLineConditional

Inherits:
Cop
  • Object
show all
Includes:
OnNormalIfUnless
Defined in:
lib/rubocop/cop/style/one_line_conditional.rb

Overview

TODO: Make configurable. Checks for uses of if/then/else/end on a single line.

Constant Summary collapse

MSG =
'Favor the ternary operator (`?:`) ' \
'over `%s/then/else/end` constructs.'

Constants included from Util

Util::ASGN_NODES, Util::BASIC_LITERALS, Util::EQUALS_ASGN_NODES, Util::LITERALS, Util::OPERATOR_METHODS, Util::PROC_NEW_NODE, Util::SHORTHAND_ASGN_NODES

Instance Attribute Summary

Attributes inherited from Cop

#config, #corrections, #offenses, #processed_source

Instance Method Summary collapse

Methods included from OnNormalIfUnless

#case_else_clause, #if_else_clause, #invoke_hook_for_normal_if_unless, #on_if

Methods included from IfNode

#elsif?, #if_else?, #if_node_parts, #modifier_if?, #ternary_op?

Methods inherited from Cop

#add_offense, all, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, cop_name, #cop_name, cop_type, #correct, #debug?, #details, #display_cop_names?, #display_style_guide?, #excluded_file?, #extra_details?, inherited, #initialize, #join_force?, lint?, match?, #message, non_rails, qualified_cop_name, rails?, #reference_url, #relevant_file?, #style_guide_url

Methods included from NodePattern::Macros

#def_node_matcher, #def_node_search

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #support_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

begins_its_line?, block_length, command?, comment_line?, const_name, directions, first_part_of_call_chain, lambda?, lambda_or_proc?, line_range, move_pos, numeric_range_size, on_node, operator?, parentheses?, proc?, range_with_surrounding_comma, range_with_surrounding_space, source_range, strip_quotes, within_node?

Methods included from PathUtil

hidden?, issue_deprecation_warning, match_path?, relative_path

Constructor Details

This class inherits a constructor from RuboCop::Cop::Cop

Instance Method Details

#on_normal_if_unless(node) ⇒ Object


14
15
16
17
18
19
20
21
# File 'lib/rubocop/cop/style/one_line_conditional.rb', line 14

def on_normal_if_unless(node)
  exp = node.loc.expression.source
  return if exp.include?("\n")
  return unless node.loc.respond_to?(:else) && node.loc.else
  condition = exp.include?('if') ? 'if' : 'unless'

  add_offense(node, :expression, format(MSG, condition))
end