Class: RuboCop::Cop::Style::Semicolon

Inherits:
Cop
  • Object
show all
Defined in:
lib/rubocop/cop/style/semicolon.rb

Overview

This cop checks for multiple expressions placed on the same line. It also checks for lines terminated with a semicolon.

Constant Summary collapse

MSG =
'Do not use semicolons to terminate expressions.'

Constants included from Util

Util::ASGN_NODES, Util::EQUALS_ASGN_NODES, Util::OPERATOR_METHODS, Util::PROC_NEW_NODE, Util::SHORTHAND_ASGN_NODES

Instance Attribute Summary

Attributes inherited from Cop

#config, #corrections, #offenses, #processed_source

Instance Method Summary collapse

Methods inherited from Cop

#add_offense, all, #autocorrect?, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, cop_name, #cop_name, cop_name_with_namespace, cop_type, #debug?, #display_cop_names?, inherited, #initialize, #join_force?, lint?, #message, non_rails, qualified_cop_name, rails?, #relevant_file?, #support_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

begins_its_line?, block_length, command?, comment_line?, const_name, first_part_of_call_chain, lambda?, lambda_or_proc?, line_range, numeric_range_size, on_node, operator?, parentheses?, proc?, range_with_surrounding_space, source_range, strip_quotes, within_node?

Methods included from PathUtil

issue_deprecation_warning, match_path?, relative_path

Constructor Details

This class inherits a constructor from RuboCop::Cop::Cop

Instance Method Details

#investigate(processed_source) ⇒ Object


11
12
13
14
15
16
# File 'lib/rubocop/cop/style/semicolon.rb', line 11

def investigate(processed_source)
  return unless processed_source.ast
  @processed_source = processed_source

  check_for_line_terminator
end

#on_begin(node) ⇒ Object


18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
# File 'lib/rubocop/cop/style/semicolon.rb', line 18

def on_begin(node)
  return if cop_config['AllowAsExpressionSeparator']
  exprs = node.children

  return if exprs.size < 2

  # create a map matching lines to the number of expressions on them
  exprs_lines = exprs.map { |e| e.loc.expression.line }
  lines = exprs_lines.group_by { |i| i }

  # every line with more than 1 expression on it is an offense
  lines.each do |line, expr_on_line|
    next unless expr_on_line.size > 1
    # TODO: Find the correct position of the semicolon. We don't know
    # if the first semicolon on the line is a separator of
    # expressions. It's just a guess.
    column = @processed_source[line - 1].index(';')
    convention_on(line, column, !:last_on_line)
  end
end