Class: RuboCop::Cop::RSpec::AnyInstance

Inherits:
Base
  • Object
show all
Defined in:
lib/rubocop/cop/rspec/any_instance.rb

Overview

Check that instances are not being stubbed globally.

Prefer instance doubles over stubbing any instance of a class

Examples:

# bad
describe MyClass do
  before { allow_any_instance_of(MyClass).to receive(:foo) }
end

# good
describe MyClass do
  let(:my_instance) { instance_double(MyClass) }

  before do
    allow(MyClass).to receive(:new).and_return(my_instance)
    allow(my_instance).to receive(:foo)
  end
end

Constant Summary collapse

MSG =
'Avoid stubbing using `%<method>s`.'
RESTRICT_ON_SEND =
%i[
  any_instance
  allow_any_instance_of
  expect_any_instance_of
].freeze

Instance Method Summary collapse

Methods inherited from Base

inherited, #on_new_investigation

Methods included from RSpec::Language::NodePattern

#block_pattern, #send_pattern

Methods included from RSpec::Language

#example?, #example_group?, #example_group_with_body?, #hook?, #include?, #let?, #rspec?, #shared_group?, #spec_group?, #subject?

Instance Method Details

#on_send(node) ⇒ Object


33
34
35
# File 'lib/rubocop/cop/rspec/any_instance.rb', line 33

def on_send(node)
  add_offense(node, message: format(MSG, method: node.method_name))
end