Class: RailsBestPractices::Reviews::UseBeforeFilterReview

Inherits:
Review
  • Object
show all
Defined in:
lib/rails_best_practices/reviews/use_before_filter_review.rb

Overview

Review a controller file to make sure to use before_filter to remove duplicated first code line_number in different action.

See the best practice detailed here https://rails-bestpractices.com/posts/2010/07/24/use-before_filter/

Implementation:

Review process:

check all first code line_number in method definitions (actions),
if they are duplicated, then they should be moved to before_filter.

Constant Summary

Constants inherited from Core::Check

Core::Check::ALL_FILES, Core::Check::CAPFILE, Core::Check::CONFIG_FILES, Core::Check::CONTROLLER_FILES, Core::Check::DEPLOY_FILES, Core::Check::GEMFILE_LOCK, Core::Check::HELPER_FILES, Core::Check::INITIALIZER_FILES, Core::Check::MAILER_FILES, Core::Check::MIGRATION_FILES, Core::Check::MODEL_FILES, Core::Check::PARTIAL_VIEW_FILES, Core::Check::ROUTE_FILES, Core::Check::SCHEMA_FILE, Core::Check::SKIP_FILES, Core::Check::VIEW_FILES

Instance Method Summary collapse

Methods inherited from Review

#model_associations, #model_attributes, #models, #remember_variable_use_count, #reset_variable_use_count, #variable, #variable_use_count

Methods inherited from Core::Check

#add_error, debug, debug?, #errors, #is_ignored?, #is_interesting_file?, #method_missing, #parse_file?, #regex_ignored_files, #url, url

Constructor Details

#initialize(options = {}) ⇒ UseBeforeFilterReview

Returns a new instance of UseBeforeFilterReview.



21
22
23
24
 
# File 'lib/rails_best_practices/reviews/use_before_filter_review.rb', line 21

def initialize(options = {})
  super()
  @customize_count = options['customize_count'] || 2
end

Dynamic Method Handling

This class handles dynamic methods through the method_missing method in the class RailsBestPractices::Core::Check