Class: Hone::Patterns::MapCompact

Inherits:
Base
  • Object
show all
Defined in:
lib/hone/patterns/map_compact.rb

Overview

Pattern: array.map { }.compact -> array.filter_map { }

map.compact creates an intermediate array from map that may contain nils, then compacts it. filter_map combines both operations avoiding the intermediate allocation.

Instance Attribute Summary

Attributes inherited from Base

#findings

Instance Method Summary collapse

Methods inherited from Base

#add_finding, inherited, #initialize, scan_file

Constructor Details

This class inherits a constructor from Hone::Patterns::Base

Instance Method Details

#visit_call_node(node) ⇒ Object 



14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
 
# File 'lib/hone/patterns/map_compact.rb', line 14

def visit_call_node(node)
  super

  # Look for: .compact where receiver is .map with a block
  return unless node.name == :compact

  receiver = node.receiver
  return unless receiver.is_a?(Prism::CallNode)
  return unless receiver.name == :map && block_attached?(receiver)

  add_finding(
    node,
    message: "Use `.filter_map { }` instead of `.map { }.compact` to avoid intermediate array with nils",
    speedup: "Avoids intermediate array with nils"
  )
end