Class: Brakeman::CheckForgerySetting

Inherits:
BaseCheck show all
Defined in:
lib/brakeman/checks/check_forgery_setting.rb

Overview

Checks that protect_from_forgery is set in the ApplicationController.

Also warns for CSRF weakness in certain versions of Rails: groups.google.com/group/rubyonrails-security/browse_thread/thread/2d95a3cc23e03665

Constant Summary

Constants inherited from BaseCheck

BaseCheck::CONFIDENCE

Constants included from Util

Util::ALL_PARAMETERS, Util::COOKIES, Util::COOKIES_SEXP, Util::PARAMETERS, Util::PARAMS_SEXP, Util::PATH_PARAMETERS, Util::QUERY_PARAMETERS, Util::REQUEST_ENV, Util::REQUEST_PARAMETERS, Util::REQUEST_PARAMS, Util::SESSION, Util::SESSION_SEXP

Constants inherited from SexpProcessor

SexpProcessor::VERSION

Instance Attribute Summary

Attributes inherited from BaseCheck

#tracker, #warnings

Attributes inherited from SexpProcessor

#context, #env, #expected

Instance Method Summary collapse

Methods inherited from BaseCheck

#add_result, inherited, #initialize, #process_call, #process_cookies, #process_default, #process_dstr, #process_if, #process_params

Methods included from Util

#array?, #block?, #call?, #camelize, #class_name, #constant?, #contains_class?, #context_for, #cookies?, #false?, #file_by_name, #file_for, #github_url, #hash?, #hash_access, #hash_insert, #hash_iterate, #integer?, #make_call, #node_type?, #number?, #params?, #pluralize, #rails_version, #regexp?, #relative_path, #request_env?, #request_value?, #result?, #set_env_defaults, #sexp?, #string?, #string_interp?, #symbol?, #table_to_csv, #template_path_to_name, #true?, #truncate_table, #underscore

Methods included from ProcessorHelper

#process_all, #process_all!, #process_call_args, #process_call_defn?, #process_class, #process_module

Methods inherited from SexpProcessor

#in_context, #initialize, #process, processors, #scope

Constructor Details

This class inherits a constructor from Brakeman::BaseCheck

Instance Method Details

#run_check ⇒ Object 



12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
 
# File 'lib/brakeman/checks/check_forgery_setting.rb', line 12

def run_check
  app_controller = tracker.controllers[:ApplicationController]
  return unless app_controller and app_controller.ancestor? :"ActionController::Base"

  if tracker.config.allow_forgery_protection?
    warn :controller => :ApplicationController,
      :warning_type => "Cross-Site Request Forgery",
      :warning_code => :csrf_protection_disabled,
      :message => "Forgery protection is disabled",
      :confidence => CONFIDENCE[:high],
      :file => app_controller.file

  elsif app_controller and not app_controller.protect_from_forgery?

    warn :controller => :ApplicationController,
      :warning_type => "Cross-Site Request Forgery",
      :warning_code => :csrf_protection_missing,
      :message => "'protect_from_forgery' should be called in ApplicationController",
      :confidence => CONFIDENCE[:high],
      :file => app_controller.file,
      :line => app_controller.top_line

  elsif version_between? "2.1.0", "2.3.10"

    warn :controller => :ApplicationController,
      :warning_type => "Cross-Site Request Forgery",
      :warning_code => :CVE_2011_0447,
      :message => "CSRF protection is flawed in unpatched versions of Rails #{rails_version} (CVE-2011-0447). Upgrade to 2.3.11 or apply patches as needed",
      :confidence => CONFIDENCE[:high],
      :gem_info => gemfile_or_environment,
      :link_path => "https://groups.google.com/d/topic/rubyonrails-security/LZWjzCPgNmU/discussion"

  elsif version_between? "3.0.0", "3.0.3"

    warn :controller => :ApplicationController,
      :warning_type => "Cross-Site Request Forgery",
      :warning_code => :CVE_2011_0447,
      :message => "CSRF protection is flawed in unpatched versions of Rails #{rails_version} (CVE-2011-0447). Upgrade to 3.0.4 or apply patches as needed",
      :confidence => CONFIDENCE[:high],
      :gem_info => gemfile_or_environment,
      :link_path => "https://groups.google.com/d/topic/rubyonrails-security/LZWjzCPgNmU/discussion"
  elsif version_between? "4.0.0", "100.0.0" and forgery_opts = app_controller.options[:protect_from_forgery]

    unless forgery_opts.is_a?(Array) and sexp?(forgery_opts.first) and
        access_arg = hash_access(forgery_opts.first.first_arg, :with) and symbol? access_arg and
        access_arg.value == :exception

      args = {
        :controller => :ApplicationController,
        :warning_type => "Cross-Site Request Forgery",
        :warning_code => :csrf_not_protected_by_raising_exception,
        :message => "protect_from_forgery should be configured with 'with: :exception'",
        :confidence => CONFIDENCE[:med],
        :file => app_controller.file
      }

      args.merge!(:code => forgery_opts.first) if forgery_opts.is_a?(Array)

      warn args
    end
  end
end