Class: Brakeman::CheckBasicAuth
- Inherits:
-
BaseCheck
- Object
- SexpProcessor
- BaseCheck
- Brakeman::CheckBasicAuth
- Defined in:
- lib/brakeman/checks/check_basic_auth.rb
Overview
Checks if password is stored in controller when using http_basic_authenticate_with
Only for Rails >= 3.1
Constant Summary
Constants inherited from BaseCheck
Constants included from Util
Util::ALL_PARAMETERS, Util::COOKIES, Util::COOKIES_SEXP, Util::PARAMETERS, Util::PARAMS_SEXP, Util::PATH_PARAMETERS, Util::QUERY_PARAMETERS, Util::REQUEST_ENV, Util::REQUEST_PARAMETERS, Util::REQUEST_PARAMS, Util::SESSION, Util::SESSION_SEXP
Constants inherited from SexpProcessor
Instance Attribute Summary
Attributes inherited from BaseCheck
Attributes inherited from SexpProcessor
Instance Method Summary collapse
- #check_basic_auth_filter ⇒ Object
-
#check_basic_auth_request ⇒ Object
Look for authenticate_or_request_with_http_basic do |username, password| username == “foo” && password == “bar” end.
- #get_password(call) ⇒ Object
-
#include_password_literal?(result) ⇒ Boolean
Check if the block of a result contains a comparison of password to string.
-
#process_call(exp) ⇒ Object
Looks for :== calls on password var.
- #run_check ⇒ Object
Methods inherited from BaseCheck
#add_result, inherited, #initialize, #process_cookies, #process_default, #process_if, #process_params, #process_string_interp
Methods included from Util
#array?, #block?, #call?, #camelize, #contains_class?, #context_for, #cookies?, #false?, #file_by_name, #file_for, #hash?, #hash_access, #hash_insert, #hash_iterate, #integer?, #make_call, #node_type?, #number?, #params?, #pluralize, #regexp?, #relative_path, #request_env?, #request_value?, #result?, #set_env_defaults, #sexp?, #string?, #symbol?, #table_to_csv, #true?, #truncate_table, #underscore
Methods included from ProcessorHelper
#class_name, #process_all, #process_all!, #process_call_args, #process_module
Methods inherited from SexpProcessor
#error_handler, #in_context, #initialize, #process, #process_dummy, #scope
Constructor Details
This class inherits a constructor from Brakeman::BaseCheck
Instance Method Details
#check_basic_auth_filter ⇒ Object
19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 |
# File 'lib/brakeman/checks/check_basic_auth.rb', line 19 def check_basic_auth_filter controllers = tracker.controllers.select do |name, c| c[:options][:http_basic_authenticate_with] end Hash[controllers].each do |name, controller| controller[:options][:http_basic_authenticate_with].each do |call| if pass = get_password(call) and string? pass warn :controller => name, :warning_type => "Basic Auth", :warning_code => :basic_auth_password, :message => "Basic authentication password stored in source code", :code => call, :confidence => 0, :file => controller[:file] break end end end end |
#check_basic_auth_request ⇒ Object
Look for
authenticate_or_request_with_http_basic do |username, password|
username == "foo" && password == "bar"
end
46 47 48 49 50 51 52 53 54 55 56 57 |
# File 'lib/brakeman/checks/check_basic_auth.rb', line 46 def check_basic_auth_request tracker.find_call(:target => nil, :method => :authenticate_or_request_with_http_basic).each do |result| if include_password_literal? result warn :result => result, :code => @include_password, :warning_type => "Basic Auth", :warning_code => :basic_auth_password, :message => "Basic authentication password stored in source code", :confidence => 0 end end end |
#get_password(call) ⇒ Object
82 83 84 85 86 87 88 |
# File 'lib/brakeman/checks/check_basic_auth.rb', line 82 def get_password call arg = call.first_arg return false if arg.nil? or not hash? arg hash_access(arg, :password) end |
#include_password_literal?(result) ⇒ Boolean
Check if the block of a result contains a comparison of password to string
60 61 62 63 64 65 |
# File 'lib/brakeman/checks/check_basic_auth.rb', line 60 def include_password_literal? result @password_var = result[:block_args].last @include_password = false process result[:block] @include_password end |
#process_call(exp) ⇒ Object
Looks for :== calls on password var
68 69 70 71 72 73 74 75 76 77 78 79 80 |
# File 'lib/brakeman/checks/check_basic_auth.rb', line 68 def process_call exp target = exp.target if node_type?(target, :lvar) and target.value == @password_var and exp.method == :== and string? exp.first_arg @include_password = exp end exp end |
#run_check ⇒ Object
12 13 14 15 16 17 |
# File 'lib/brakeman/checks/check_basic_auth.rb', line 12 def run_check return if version_between? "0.0.0", "3.0.99" check_basic_auth_filter check_basic_auth_request end |