Class: RuboCop::Cop::Lint::ItWithoutArgumentsInBlock

Inherits:
Base
  • Object
show all
Includes:
Macros
Defined in:
lib/rubocop/cop/lint/it_without_arguments_in_block.rb

Overview

Emulates the following Ruby warning in Ruby 3.3.

source,ruby

$ ruby -e ‘0.times { it }’ -e:1: warning: ‘it` calls without arguments will refer to the first block param in Ruby 3.4; use it() or self.it

‘it` calls without arguments will refer to the first block param in Ruby 3.4. So use `it()` or `self.it` to ensure compatibility.

Examples:


# bad
do_something { it }

# good
do_something { it() }
do_something { self.it }

Constant Summary collapse

MSG = 
'`it` calls without arguments will refer to the first block param in Ruby 3.4; ' \
'use `it()` or `self.it`.'

Constants inherited from Base

Base::RESTRICT_ON_SEND

Instance Attribute Summary

Attributes inherited from Base

#config, #processed_source

Instance Method Summary collapse

Methods inherited from Base

#active_support_extensions_enabled?, #add_global_offense, #add_offense, #always_autocorrect?, autocorrect_incompatible_with, badge, #begin_investigation, callbacks_needed, #callbacks_needed, #config_to_allow_offenses, #config_to_allow_offenses=, #contextual_autocorrect?, #cop_config, cop_name, #cop_name, department, documentation_url, exclude_from_registry, #excluded_file?, #external_dependency_checksum, inherited, #initialize, #inspect, joining_forces, lint?, match?, #message, #offenses, #on_investigation_end, #on_new_investigation, #on_other_file, #parse, #parser_engine, #ready, #relevant_file?, requires_gem, support_autocorrect?, support_multiple_source?, #target_rails_version, #target_ruby_version

Methods included from ExcludeLimit

#exclude_limit

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #autocorrect_with_disable_uncorrectable?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

silence_warnings

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#deprecated_it_method?(node) ⇒ Boolean

Returns:

  • (Boolean) 


48
49
50
51
52
 
# File 'lib/rubocop/cop/lint/it_without_arguments_in_block.rb', line 48

def deprecated_it_method?(node)
  return false unless node.method?(:it)

  !node.receiver && node.arguments.empty? && !node.parenthesized? && !node.block_literal?
end

#on_block(node) ⇒ Object

rubocop:disable InternalAffairs/NumblockHandler



33
34
35
36
37
38
39
40
41
42
43
44
45
46
 
# File 'lib/rubocop/cop/lint/it_without_arguments_in_block.rb', line 33

def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
  return unless (body = node.body)
  return unless node.arguments.empty_and_without_delimiters?

  if body.send_type? && deprecated_it_method?(body)
    add_offense(body)
  else
    body.each_descendant(:send).each do |send_node|
      next unless deprecated_it_method?(send_node)

      add_offense(send_node)
    end
  end
end