Class: RuboCop::Cop::Performance::ParallelAssignment
- Defined in:
- lib/rubocop/cop/performance/parallel_assignment.rb
Overview
Checks for simple usages of parallel assignment. This will only complain when the number of variables being assigned matched the number of assigning variables.
Constant Summary collapse
- MSG =
'Do not use parallel assignment.'
Constants included from Util
Util::ASGN_NODES, Util::EQUALS_ASGN_NODES, Util::OPERATOR_METHODS, Util::PROC_NEW_NODE, Util::SHORTHAND_ASGN_NODES
Instance Attribute Summary
Attributes inherited from Cop
#config, #corrections, #offenses, #processed_source
Instance Method Summary collapse
Methods inherited from Cop
#add_offense, all, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, #cop_name, cop_name, cop_type, #correct, #debug?, #display_cop_names?, #display_style_guide?, inherited, #initialize, #join_force?, lint?, match?, #message, non_rails, qualified_cop_name, rails?, #relevant_file?, #style_guide_url
Methods included from AutocorrectLogic
#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #support_autocorrect?
Methods included from IgnoredNode
#ignore_node, #ignored_node?, #part_of_ignored_node?
Methods included from Util
begins_its_line?, block_length, command?, comment_line?, const_name, directions, first_part_of_call_chain, lambda?, lambda_or_proc?, line_range, move_pos, numeric_range_size, on_node, operator?, parentheses?, proc?, range_with_surrounding_comma, range_with_surrounding_space, source_range, strip_quotes, within_node?
Methods included from PathUtil
hidden?, issue_deprecation_warning, match_path?, relative_path
Constructor Details
This class inherits a constructor from RuboCop::Cop::Cop
Instance Method Details
#autocorrect(node) ⇒ Object
47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 |
# File 'lib/rubocop/cop/performance/parallel_assignment.rb', line 47 def autocorrect(node) left, right = *node lambda do |corrector| l_vars = extract_sources(left) r_vars = extract_sources(right) groups = l_vars.zip(r_vars) assignment = groups.map { |pair| pair.join(' = ') } space_offset = node.loc.expression.column corrector.replace(node.loc.expression, assignment.join("\n" << ' ' * space_offset)) end end |
#on_masgn(node) ⇒ Object
25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 |
# File 'lib/rubocop/cop/performance/parallel_assignment.rb', line 25 def on_masgn(node) left, right = *node left_elements = *left right_elements = [*right].compact # edge case for one constant # only complain when the number of variables matches return if left_elements.size != right_elements.size # account for edge cases using one variable with a comma return if left_elements.size == 1 # allow mass assignment as the return of a method call return if right.block_type? || right.send_type? # allow mass assignment when using splat return if (left_elements + right_elements).any?(&:splat_type?) return if variable_reassignment?(left_elements, right_elements) add_offense(node, :expression) end |