Class: RuboCop::Cop::FormulaAuditStrict::ComponentsRedundancy

Inherits:
RuboCop::Cop::FormulaCop show all
Defined in:
Library/Homebrew/rubocops/components_redundancy_cop.rb

Overview

This cop checks if redundant components are present and other component errors

  • `url|checksum|mirror` should be inside `stable` block

  • `head` and `head do` should not be simultaneously present

  • `bottle :unneeded/:disable` and `bottle do` should not be simultaneously present

Constant Summary

HEAD_MSG =
"`head` and `head do` should not be simultaneously present".freeze
BOTTLE_MSG =
"`bottle :modifier` and `bottle do` should not be simultaneously present".freeze

Instance Attribute Summary

Attributes inherited from RuboCop::Cop::FormulaCop

#file_path

Instance Method Summary collapse

Methods inherited from RuboCop::Cop::FormulaCop

#audit_comments, #audit_urls, #block_size, #caveats_strings, #check_precedence, #class_name, #component_precedes?, #depends_on?, #depends_on_name_type?, #end_column, #expression_negated?, #find_all_blocks, #find_block, #find_blocks, #find_const, #find_every_method_call_by_name, #find_instance_call, #find_instance_method_call, #find_method_calls_by_name, #find_method_def, #find_method_with_args, #find_node_method_by_name, #find_strings, #format_component, #formula_tap, #get_checksum_node, #line_number, #line_start_column, #method_called?, #method_called_ever?, #method_called_in_block?, #method_name, #node_equals?, #offending_node, #on_class, #parameters, #parameters_passed?, #problem, #regex_match_group, #size, #source_buffer, #start_column, #string_content, #versioned_formula?

Instance Method Details

#audit_formula(_node, _class_node, _parent_class_node, body_node) ⇒ Object



16
17
18
19
20
21
22
23
24
25
26
27
28
29
# File 'Library/Homebrew/rubocops/components_redundancy_cop.rb', line 16

def audit_formula(_node, _class_node, _parent_class_node, body_node)
  stable_block = find_block(body_node, :stable)
  if stable_block
    [:url, :sha256, :mirror].each do |method_name|
      problem "`#{method_name}` should be put inside `stable` block" if method_called?(body_node, method_name)
    end
  end

  problem HEAD_MSG if method_called?(body_node, :head) &&
                      find_block(body_node, :head)

  problem BOTTLE_MSG if method_called?(body_node, :bottle) &&
                        find_block(body_node, :bottle)
end