Class: RuboCop::Cop::FormulaAudit::Patches

Inherits:
RuboCop::Cop::FormulaCop show all
Defined in:
Library/Homebrew/rubocops/patches.rb

Overview

This cop audits patches in formulae.

Instance Attribute Summary

Attributes inherited from RuboCop::Cop::FormulaCop

#file_path

Instance Method Summary collapse

Methods inherited from RuboCop::Cop::FormulaCop

#audit_comments, #audit_urls, #block_size, #caveats_strings, #check_precedence, #class_name, #component_precedes?, #depends_on?, #depends_on_name_type?, #end_column, #expression_negated?, #find_all_blocks, #find_block, #find_blocks, #find_const, #find_every_func_call_by_name, #find_every_method_call_by_name, #find_instance_call, #find_instance_method_call, #find_method_calls_by_name, #find_method_def, #find_method_with_args, #find_node_method_by_name, #find_strings, #format_component, #formula_tap, #get_checksum_node, #method_called?, #method_called_ever?, #method_called_in_block?, #method_name, #node_equals?, #offending_node, #on_class, #parameters, #parameters_passed?, #size, #versioned_formula?

Methods included from HelperFunctions

#line_number, #line_start_column, #problem, #regex_match_group, #source_buffer, #start_column, #string_content

Instance Method Details

#audit_formula(node, _class_node, _parent_class_node, body) ⇒ Object 


12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
 
# File 'Library/Homebrew/rubocops/patches.rb', line 12

def audit_formula(node, _class_node, _parent_class_node, body)
  @full_source_content = source_buffer(node).source

  external_patches = find_all_blocks(body, :patch)
  external_patches.each do |patch_block|
    url_node = find_every_method_call_by_name(patch_block, :url).first
    url_string = parameters(url_node).first
    patch_problems(url_string)
  end

  inline_patches = find_every_method_call_by_name(body, :patch)
  inline_patches.each { |patch| inline_patch_problems(patch) }

  if inline_patches.empty? && patch_end?
    offending_patch_end_node(node)
    problem "patch is missing 'DATA'"
  end

  patches_node = find_method_def(body, :patches)
  return if patches_node.nil?

  legacy_patches = find_strings(patches_node)
  problem "Use the patch DSL instead of defining a 'patches' method"
  legacy_patches.each { |p| patch_problems(p) }
end