Class: RuboCop::Cop::Lint::AmbiguousBlockAssociation

Inherits:
Base
  • Object
show all
Includes:
IgnoredMethods
Defined in:
lib/rubocop/cop/lint/ambiguous_block_association.rb

Overview

This cop checks for ambiguous block association with method when param passed without parentheses.

This cop can customize ignored methods with `IgnoredMethods`.

Examples:


# bad
some_method a { |val| puts val }

# good
# With parentheses, there's no ambiguity.
some_method(a { |val| puts val })
# or (different meaning)
some_method(a) { |val| puts val }

# good
# Operator methods require no disambiguation
foo == bar { |b| b.baz }

# good
# Lambda arguments require no disambiguation
foo = ->(bar) { bar.baz }

IgnoredMethods: [change]


# good
expect { do_something }.to change { object.attribute }

Constant Summary collapse

MSG =
'Parenthesize the param `%<param>s` to make sure that the ' \
'block will be associated with the `%<method>s` method ' \
'call.'

Constants inherited from Base

Base::RESTRICT_ON_SEND

Instance Attribute Summary

Attributes inherited from Base

#config, #processed_source

Instance Method Summary collapse

Methods included from IgnoredMethods

#ignored_method?, #ignored_methods, included

Methods inherited from Base

#add_global_offense, #add_offense, autocorrect_incompatible_with, badge, #callbacks_needed, callbacks_needed, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, #cop_name, cop_name, department, documentation_url, exclude_from_registry, #excluded_file?, #external_dependency_checksum, inherited, #initialize, joining_forces, lint?, match?, #offenses, #on_investigation_end, #on_new_investigation, #on_other_file, #parse, #ready, #relevant_file?, support_autocorrect?, support_multiple_source?, #target_rails_version, #target_ruby_version

Methods included from ExcludeLimit

#exclude_limit

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

silence_warnings

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#on_send(node) ⇒ Object Also known as: on_csend


43
44
45
46
47
48
49
50
51
52
# File 'lib/rubocop/cop/lint/ambiguous_block_association.rb', line 43

def on_send(node)
  return unless node.arguments?

  return unless ambiguous_block_association?(node)
  return if node.parenthesized? || node.last_argument.lambda? || allowed_method?(node)

  message = message(node)

  add_offense(node, message: message)
end