Class: RuboCop::Cop::Style::RedundantException

Inherits:
Cop
  • Object
show all
Defined in:
lib/rubocop/cop/style/redundant_exception.rb

Overview

This cop checks for RuntimeError as the argument of raise/fail.

Currently it checks for code like this:

Examples:


raise RuntimeError, 'message'

Constant Summary collapse

MSG =
'Redundant `RuntimeError` argument can be removed.'
TARGET_NODE =
s(:const, nil, :RuntimeError)

Constants included from Util

Util::ASGN_NODES, Util::EQUALS_ASGN_NODES, Util::OPERATOR_METHODS, Util::PROC_NEW_NODE, Util::SHORTHAND_ASGN_NODES

Instance Attribute Summary

Attributes inherited from Cop

#config, #corrections, #offenses, #processed_source

Instance Method Summary collapse

Methods inherited from Cop

#add_offense, all, #autocorrect?, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, #cop_name, cop_name, cop_name_with_namespace, cop_type, #debug?, #display_cop_names?, inherited, #initialize, #join_force?, lint?, #message, non_rails, qualified_cop_name, rails?, #relevant_file?, #support_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

begins_its_line?, block_length, command?, comment_line?, const_name, first_part_of_call_chain, lambda?, lambda_or_proc?, line_range, numeric_range_size, on_node, operator?, parentheses?, proc?, range_with_surrounding_comma, range_with_surrounding_space, source_range, strip_quotes, within_node?

Methods included from PathUtil

issue_deprecation_warning, match_path?, relative_path

Constructor Details

This class inherits a constructor from RuboCop::Cop::Cop

Instance Method Details

#autocorrect(node) ⇒ Object

switch raise RuntimeError, 'message' to raise 'message'



31
32
33
34
35
36
37
38
39
40
# File 'lib/rubocop/cop/style/redundant_exception.rb', line 31

def autocorrect(node)
  @corrections << lambda do |corrector|
    start_range = node.loc.expression.begin
    no_comma = range_with_surrounding_comma(node.loc.expression.end,
                                            :right)
    comma_range = start_range.join(no_comma)
    final_range = range_with_surrounding_space(comma_range, :right)
    corrector.replace(final_range, '')
  end
end

#on_send(node) ⇒ Object



18
19
20
21
22
23
24
25
26
27
28
# File 'lib/rubocop/cop/style/redundant_exception.rb', line 18

def on_send(node)
  return unless command?(:raise, node) || command?(:fail, node)

  _receiver, _selector, *args = *node

  return unless args.size == 2

  first_arg, = *args

  add_offense(first_arg, :expression) if first_arg == TARGET_NODE
end