Class: RuboCop::Cop::RSpec::FactoryBot::AttributeDefinedStatically

Inherits:
Base
  • Object
show all
Extended by:
AutoCorrector
Defined in:
lib/rubocop/cop/rspec/factory_bot/attribute_defined_statically.rb

Overview

Always declare attribute values as blocks.

Examples:

# bad
kind [:active, :rejected].sample

# good
kind { [:active, :rejected].sample }

# bad
closed_at 1.day.from_now

# good
closed_at { 1.day.from_now }

# bad
count 1

# good
count { 1 }

Constant Summary collapse

MSG =
'Use a block to declare attribute values.'

Instance Method Summary collapse

Methods inherited from Base

inherited, #on_new_investigation

Methods included from RSpec::Language::NodePattern

#block_pattern, #send_pattern

Methods included from RSpec::Language

#example?, #example_group?, #example_group_with_body?, #hook?, #include?, #let?, #rspec?, #shared_group?, #spec_group?, #subject?

Instance Method Details

#factory_attributes(node) ⇒ Object


38
39
40
# File 'lib/rubocop/cop/rspec/factory_bot/attribute_defined_statically.rb', line 38

def_node_matcher :factory_attributes, <<-PATTERN
  (block (send _ #attribute_defining_method? ...) _ { (begin $...) $(send ...) } )
PATTERN

#on_block(node) ⇒ Object


42
43
44
45
46
47
48
49
50
51
52
53
54
# File 'lib/rubocop/cop/rspec/factory_bot/attribute_defined_statically.rb', line 42

def on_block(node)
  attributes = factory_attributes(node) || []
  attributes = [attributes] unless attributes.is_a?(Array) # rubocop:disable Style/ArrayCoercion, Lint/RedundantCopDisableDirective

  attributes.each do |attribute|
    next unless offensive_receiver?(attribute.receiver, node)
    next if proc?(attribute) || association?(attribute.first_argument)

    add_offense(attribute) do |corrector|
      autocorrect(corrector, attribute)
    end
  end
end

#value_matcher(node) ⇒ Object


33
34
35
# File 'lib/rubocop/cop/rspec/factory_bot/attribute_defined_statically.rb', line 33

def_node_matcher :value_matcher, <<-PATTERN
  (send _ !#reserved_method? $...)
PATTERN