Formalize your Pull Request etiquette.
What is Danger?
Danger runs after your CI, automating your team’s conventions surrounding code review.
This provides another logical step in your process, through this Danger can help lint your rote tasks in daily code review.
You can use Danger to codify your team’s norms, leaving humans to think about harder problems.
- Enforce CHANGELOGs
- Enforce links to Trello/JIRA in PR/MR bodies
- Enforce using descriptive labels
- Look out for common anti-patterns
- Highlight interesting build artifacts
- Give specific files extra focus
Danger provides the glue to let you build out the rules specific to your team’s culture, offering useful metadata and a comprehensive plugin system to share common issues.
Alright. So, actually, you may be in the wrong place. From here on in, this README is going to be for people who are interested in working on and improving on Danger.
We keep all of the end-user documentation at https://danger.systems.
I’m here to help out!
Brilliant. So, let’s get you set up.
“h git clone https://github.com/danger/danger.git cd danger bundle install bundle exec rake spec
This sets everything up and runs all of the tests.
The code you write may end up in the public part of the website — the easiest way to tell is that it is vastly overdocumented. If you are working in a space that looks over-documented, please be extra considerate to add documentation. We expect the consumers of that documentation to be non-rubyists, thus you should avoid specific jargon and try to provide duplicate overlapping examples.
So far, we’ve not really figured out the right way to make tests for our CLI commands. When we have done so, they’ve ended up being brittle. So, ideally, try to move any logic that would go into a command into separate classes, and test those. We’re okay with the command not having coverage, but ideally the classes that make up what it does will.
I’d strongly recommend using
bundle exec guard to run your tests as you work. Any changes you make in the lib, or specs will have corresponding tests run instantly.
Ruby is super dynamic. One of the best ways to debug Ruby code is by using pry. We include pry for developers: when you have a problem, copy these two lines just before your problem and follow the instructions from “I Want To Be A Danger Wizard.”
“by require ‘pry’ binding.pry
License, Contributor’s Guidelines and Code of Conduct
We try to keep as much discussion as possible in GitHub issues, but also have a pretty inactive Slack — if you’d like an invite, ping @Orta a DM on Twitter with your email. It’s mostly interesting if you want to stay on top of Danger without all the emails from GitHub.
This project is open source under the MIT license, which means you have full access to the source code and can modify it to fit your own needs.
This project subscribes to the Moya Contributors Guidelines which TLDR: means we give out push access easily and often.